[PATCH v4 2/8] reg.exe: Add path_get_key() to remove boilerplate

Stefan Dösinger stefandoesinger at gmail.com
Mon Oct 13 10:06:21 CDT 2014


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Am 2014-10-13 16:51, schrieb Jonathan Vollebregt:
> Trailing spaces are valid key names (At least in wine, I imagine
> in native too)
Sorry, I meant (and the example used it that way) leading spaces. That
would affect the way you check for remote keys. Obviously trailing
spaces need tests too, but if advapi32 handles them you don't need
extra handling in the implementation.

> The closest thing I have to a native windows system is testbot and
> I doubt you'd want me clogging it up just to find out what the
> proper reg inputs are.
> 
> If anyone can write tests for the rest, that would be great!
That's exactly what the testbot is there for. No excuses ;-) . But
you'll be happier with your own windows machine (or VM) because it has
a way faster response time than the testbot.

There's no point in changing the argument handling if we don't know
that the changes are actually correct.

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQIcBAEBAgAGBQJUO+ptAAoJEN0/YqbEcdMwO9sQAJa6f93jGH7QXeu+HBE9YcIf
HVA4LL8weSW8SxR0LuHuEfyqWtsoTC0+gBTEznZ9FdLeE0XhCzzFVaNKtZzAk5A7
3RpotewlDWa+sIsOi/ZoXxpFUX/qXqNPKJ+xC8rmPx2AtCisAwlYUcJcK5CotGzG
K+L/Rbc8geb68MKOebjSVwNEXLDUqsgKehZA6DHh7NX7f/UhkIv30ahnpVAgDY5f
GVrpvS8lCoi0kl5V1vCEi0uA3EFIqLocqUpn36lCYWhJdR0acV1oHOOEqBnUfQFN
o1WTCT4d4raOBLEz72HwRLe9JiuYgrr7YZdk6LPlw8u4dSXKqyDF73aR5AiHsXYI
7z1iN5mM1SkZ06elLsMXfCoaXsHPGFHBNgj2lUh+19aWJPLg7ZUaM1QBvq/2upSL
aCRQvAVldmETKJbEkuRDwcblzZUzUo5vxr3Pdjk9Mf+Owu1r+nDONR7Q498seAdH
eR6FFt26gDpdoJzl2RUmioAEZKAHSRgRD/pGaOX0WfuKTGp/m/hv0hrami0ZygYi
v9IBgUZuk7Yn+n8ngo0TttTrtfYZuTB2sPcanIEp4QJVcdvesvz8JOX7dUCAbeHh
NPzM4R/X44To2doqjfmLyn0egCTNy4elS/GqAZ5X1VI9WfcUexRGdmBQfWImdEYh
0NjdSUEYGc5oVp4xzEcg
=VgVy
-----END PGP SIGNATURE-----



More information about the wine-devel mailing list