[PATCH 2/4] d3d9/tests: Avoid mode changes in d3d9ex' test_lost_device.

Stefan Dösinger stefandoesinger at gmail.com
Wed Oct 15 03:20:45 CDT 2014


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Am 2014-10-15 08:31, schrieb Henri Verbeet:
> If you really wanted to avoid mode changes in test_lost_device()
> you'd have to change reset_device() as well, but the test actually
> tests for return codes after a mode change. It doesn't work on the
> testbot because IIRC it starts at 1024x768.
Right, the S_PRESENT_MODE_CHANGED should have alerted me. Do you have
any idea why a successful reset brings the device into this state?

Does reset_device call IDirect3DDevice9_Reset (instead of ResetEx)
intentionally? The IDirect3DDevice9_ part suggests that it is
unintentional, but in the context of the patch that added it
(2f307a14) it makes some sense.

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2
Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/

iQIcBAEBAgAGBQJUPi5dAAoJEN0/YqbEcdMw1ZsP/R1OAUNjZXaOIY8QaJAoIcX4
uJ49wcqwq3hmbkGIsienoGv2FJ6Bap6QHzbTCbu4O17eBwYrr2wWi8KV2yqwi8pE
HMzUpvbLDxVHlmsMkfLSFG/PBSXS1biLAd0pgYgwzS3JlKx+eTTdhyyx+UoneV4s
2aSzJXq2hsoz3FFGJAiJ6/0rl3c8aI/ZbNC4i96PoXAPiURanLtnX0TlhIc6ZZEt
JKxJbxbugOlULsnIVwGRFP2suqPkLl6w4n9x9GKQSa2mSqoO/JoIg94uAkQ5DcZb
PUCnz/6n/gW6SrGQqN+4oUR1gnZu/Gk3bdiyZWVYSh7tsTBJHEt1uzsGoAAa/6xp
MXVM8nJzEEK6aUoDOa6QIliwrZhCLD8RKZwbtnXytWPUzSK/307D24ryRTYPqNLO
QUy6l+3YXhaHYl9fHqjfl9d7K/zBfHiAtk6u9xPda6dTWoopzj3QNeifE4rmYmvc
4gSui3Hj/miCA9zcoifmK5LxgWqbcWgqTx4DT7Rxdic43MpBZMeXM5gVonPcvhOn
Nl4of5VE+W5j/hv+p81ATyUM9KP+ydNQws02lEcS+747Y09Z3ubWTk98f9oKBBQP
l6tuoKAWIS6skcZWc1PBX0wCcqIkaMuhe7qdoo/tJObvd11LbMwutnNg2ZANyAjD
HaIh1E96ApXoB9TjGhuw
=EzVW
-----END PGP SIGNATURE-----



More information about the wine-devel mailing list