(resend/renumber)[4/14]dwrite: implement a list of font data for IDWriteFontFamily
Alexandre Julliard
julliard at winehq.org
Wed Sep 3 11:45:18 CDT 2014
Aric Stewart <aric at codeweavers.com> writes:
> @@ -1121,6 +1188,24 @@ static void get_font_properties(struct dwrite_font *font, HDC hdc)
> }
> }
>
> +static HRESULT create_font_from_data(struct dwrite_font_data *data, IDWriteFont **font)
> +{
> + HRESULT hr;
> + struct dwrite_font *This;
> +
> + hr = create_font_base(font);
> + if (FAILED(hr))
> + return hr;
> +
> + This = impl_from_IDWriteFont(*font);
> +
> + heap_free(This->data);
> + This->data = data;
> + InterlockedIncrement(&This->data->ref);
> +
> + return S_OK;
> +}
That looks unnecessarily complicated. Why allocate and initialize the
data only to immediately replace it?
--
Alexandre Julliard
julliard at winehq.org
More information about the wine-devel
mailing list