[PATCH 1/4] mshtml: Return E_POINTER when p is NULL in HTMLStyle_get_pixelLeft.

Jactry Zeng jactry92 at gmail.com
Tue Sep 9 04:37:25 CDT 2014


Hi Jacek,
2014-09-09 16:43 GMT+08:00 Jacek Caban <jacek at codeweavers.com>:
>
>
> Since you're adding those checks to many functions, it would probably
> make sense to move that to get_nsstyle_pixel_val.

I didn't do that because I think checking it before get_nsstyle_pixel_val
can save a function calling when p == NULL. :)

Thanks for your review! I will send a newer version.
-- 
Regards,
Jactry Zeng
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.winehq.org/pipermail/wine-devel/attachments/20140909/608f9858/attachment.html>


More information about the wine-devel mailing list