[PATCH 1/8] riched20: Stub for ITextRange interface and implement ITextDocument::Range. (resend try 4)
Huw Davies
huw at codeweavers.com
Fri Sep 12 05:36:59 CDT 2014
On Fri, Sep 12, 2014 at 06:31:01PM +0800, Jactry Zeng wrote:
>
> 2014-09-12 17:47 GMT+08:00 Huw Davies <huw at codeweavers.com>:
> >
> > > txtRge->ref = 1;
> > > IRichEditOle_AddRef(reOle);
>
> I feel little perplexed here. We want ITextRange::XXX returns CO_E_RELEASED
> when reOle and txtDoc were released. So we don't need AddRef(reOle) here?
> And then we can just pass a RichEditOleImpl into CreateITextRange().
We'd already decided that you don't need the AddRef, so I assumed you
would remove it. If you prefer to pass RichEditOleImpl then just pass
that.
Huw.
More information about the wine-devel
mailing list