[PATCH 4/5] d3d9/tests: Extend focus loss tests.

Henri Verbeet hverbeet at gmail.com
Wed Sep 24 06:21:42 CDT 2014

On 23 September 2014 23:54, Stefan Dösinger <stefandoesinger at gmail.com> wrote:
> Am 2014-09-23 13:52, schrieb Henri Verbeet:
>> I don't think the tests really support the implementation. For
>> example, they don't test multiple swapchains at all, and they
>> basically only test if WS_MINIMIZE is set or not as far as window
>> styles are concerned. I'd expect at least some basic message and
>> style tests along the lines of e.g. test_wndproc() and
>> test_window_style().
> Is the attached test what you had in mind? Mode switching is not
Something along those lines, yeah. You'll probably want to use a
wparam mask instead of multiple expected values, and I'd prefer
WA_INACTIVE over 0 in the appropriate places.

> I can extend test_window_style as well to check for WS_VISIBLE, but I
> don't see a reason to do that given the messages being sent.
You probably mostly care about WS_MINIMIZE, but it's also to verify
that there are no other style changes. I imagine this would also be
useful if we ever get around to finishing e.g. a WGL extension for
switching to/from fullscreen.

> Wrt multiple swapchains, since we don't have any tests and support for
> multi-head or CreateAdditionalSwapchain in fullscreen mode that'd be a
> rather huge detour I'd prefer not to take.
I suspect that adding tests for CreateAdditionalSwapChain() at least
would only be a modest amount of work, but without tests, I'd expect
that we should only minimize the fullscreen swapchain. Or, put a
different way, only the window that we received the message for.

More information about the wine-devel mailing list