[PATCH 2/4] ntdll/test: Add ntdll test function test_file_full_size_information

Jianqiu Zhang zhangjianqiu_133 at yeah.net
Sat Apr 4 03:07:00 CDT 2015


At 2015-04-04 15:17:13, "Nikolay Sivov" <bunglehead at gmail.com> wrote:

>Hi, Jianqiu.

>This is not exactly a test, as you're just printing a result. Same thing 
>with patch 3/4. Also to print LONGLONG values you use 
>wine_dbgstr_longlong() probably.

Hi~ Nikolay
In fact , this is my first time to submit a patch to wine community :)
I have a few questions to ask 

What does a test do?
I thought test functions is a kind of implementation of WinAPI .
I write test function and build cross test executable file and then run on Windows
to get some data I need . Then I can write the FileFsFullSizeInformation based on these data

And you said that what I wrote is not a test.Does it mean I should test whether my new function works well?
Should I use ok  and todo  macro to make my test convincing?

If I doesn't make my self clear enough~ would you please let me know and I will try to make myself clear enough.

Thanks~
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.winehq.org/pipermail/wine-devel/attachments/20150404/744c6123/attachment.html>


More information about the wine-devel mailing list