msxml3: Explicitly list acceptable libxml2->msxml node types for unknode (try 2)

Nikolay Sivov bunglehead at gmail.com
Sat Apr 4 08:55:59 CDT 2015


On 04.04.2015 16:51, Jacek Caban wrote:
> Hi Nikolay,
>
> On 01/04/15 22:41, Nikolay Sivov wrote:
>> +    switch (This->node.node->type)
>> +    {
>> +    case XML_ELEMENT_NODE:
>> +    case XML_ATTRIBUTE_NODE:
>> +    case XML_TEXT_NODE:
>> +    case XML_CDATA_SECTION_NODE:
>> +    case XML_ENTITY_REF_NODE:
>> +    case XML_ENTITY_NODE:
>> +    case XML_PI_NODE:
>> +    case XML_COMMENT_NODE:
>> +    case XML_DOCUMENT_NODE:
>> +    case XML_DOCUMENT_TYPE_NODE:
>> +    case XML_DOCUMENT_FRAG_NODE:
>> +    case XML_NOTATION_NODE:
>
> Most of those types have their own IXMLDOMNode implementations, so they
> should never be the case in here. Also, ideally we shouldn't even create
> unknode object for types that are not supported, so it should be fixed
> in create_node or its callers. Is it possible in the case that you're
> fixing?

It's only to 'fix' a clang warning about assignment of different enum 
types. I just listed all types that map directly to msxml types, it's 
not about fixing any runtime problem.

>
> Jacek
>
>




More information about the wine-devel mailing list