winecfg: add all Windows versions and accompanying error message (try 3)

Andrew Eikum aeikum at codeweavers.com
Fri Apr 10 08:04:40 CDT 2015


On Thu, Apr 09, 2015 at 05:42:36PM -0700, Jason Overland wrote:
> @@ -399,9 +401,49 @@ static void on_remove_app_click(HWND dialog)
>      SendMessageW(GetParent(dialog), PSM_CHANGED, (WPARAM) dialog, 0);
>  }
>  
> +static INT_PTR WINAPI win_ver_error_dlg_proc(HWND hwnd, UINT msg, WPARAM wParam, LPARAM lParam)

This function should be guarded by an #ifdef. On my 32-bit build, I
get:

appdefaults.c:404:90: warning: ‘win_ver_error_dlg_proc’ defined but not used [-Wunused-function]

> @@ -159,6 +159,22 @@ BEGIN
>      COMBOBOX        IDC_WINVER,100,194,145,56,CBS_DROPDOWNLIST | WS_VSCROLL | WS_TABSTOP    
>  END
>  
> +IDD_WINVERERROR DIALOGEX 100, 100, 238, 95
> +STYLE DS_SETFONT | DS_MODALFRAME | DS_FIXEDSYS | WS_POPUP | WS_CAPTION | WS_SYSMENU
> +CAPTION "Error: Invalid selection"
> +FONT 8, "MS Shell Dlg"
> +BEGIN
> +    LTEXT           "This Wine prefix is built to support 64 bit applications. \
> +                            Because the Windows version you selected does not support 64 bit applications, \
> +                            this prefix cannot be configured to mimic that version of Windows.",
> +                      IDC_STATIC,5,5,220,40
> +    CONTROL         "Please refer to \"How do I create a 32 bit wineprefix on a 64 bit system?\" \
> +                            in the \"Using Wine\" section of the <a href=\"http://wiki.winehq.org/FAQ\">Wine FAQ</a> \
> +                            for instructions on how to create a 32 bit Wine prefix.",
> +                      IDC_WIN_VER_TEXT,"SysLink",0,5,40,220,70

For some reason, this renders without a space between "the" and the
"Wine FAQ" link. Also half of the last 'x' and the period are cut off.

It could be an issue on my system. I'm not very familiar with how RC
files work.

Other than those issues, it seems to work as intended.

Andrew



More information about the wine-devel mailing list