[PATCH 2/5] wined3d: Introduce resource-type specific format flags.

Henri Verbeet hverbeet at gmail.com
Thu Apr 23 07:54:32 CDT 2015


On 23 April 2015 at 14:25, Stefan Dösinger <stefandoesinger at gmail.com> wrote:
> Am 2015-04-23 um 13:52 schrieb Henri Verbeet:
>> But now it's still going to write an ERR when it tries to create a
>> volume texture and s3tc support is unavailable. Wouldn't it make
>> more sense to just explicitly exclude volume textures by adding a
>> "desc->resource_type != WINED3D_RTYPE_VOLUME_TEXTURE" condition?
> This was intentional (hence the "otherwise" in the comment), because I
> think having an application that in any way tries to use DXTn and
> having no DXTn support is worth warning the user about. I don't have
> any objections against never writing this for volumes though. I
> seriously doubt that there's an application that doesn't need DXTn 2D
> textures but tries to create a DXTn volume texture.
>
But that's the thing, this will only make a difference for
applications that try to create DXTn volume textures, but never try to
create DXTn 2D or cube textures. But creating a DXTn volume texture is
going to fail either way, regardless of whether the driver has s3tc
support or not. So you create a situation where you're suggesting to
users that they should somehow acquire s3tc support, but already know
in advance that it isn't going to make a difference.



More information about the wine-devel mailing list