loader: Add UTC Time Zone

Philippe Groarke philippe.groarke at gmail.com
Mon Aug 3 19:34:28 CDT 2015


Hi, sorry for all the silly mistakes, this is my first patch to this project. I did see your other Time Code updates that use wine.inf: instead of loader:. I agree it is much more appropriate.

I used the name from the linked website in the source comments. I admit I wasn't sure what to use for dlt and std. I will make the appropriate changes (Etc/UTC and Coordinated Universal Time). Should I also change the name of the commit (to use wine.inf:), or would that break continuity? 

Finally, changing the subject in my format-patch output file is enough for git send-email?

Thank you,
Philippe

> On Aug 3, 2015, at 8:19 PM, Sebastian Lackner <sebastian at fds-team.de> wrote:
> 
> On 03.08.2015 16:32, Philippe Groarke wrote:
>> Fixes 39008
>> ---
>> loader/wine.inf.in | 4 ++++
>> 1 file changed, 4 insertions(+)
>> 
>> diff --git a/loader/wine.inf.in b/loader/wine.inf.in
>> index 315ef29..1627ad6 100644
>> --- a/loader/wine.inf.in
>> +++ b/loader/wine.inf.in
>> @@ -3070,6 +3070,10 @@ HKLM,%CurrentVersionNT%\Time Zones\US Mountain Standard Time,"Display",,"America
>> HKLM,%CurrentVersionNT%\Time Zones\US Mountain Standard Time,"Dlt",,"US Mountain Daylight Time"
>> HKLM,%CurrentVersionNT%\Time Zones\US Mountain Standard Time,"Std",,"US Mountain Standard Time"
>> HKLM,%CurrentVersionNT%\Time Zones\US Mountain Standard Time,"TZI",1,a4,01,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00
>> +HKLM,%CurrentVersionNT%\Time Zones\UTC,"Display",,"Etc/GMT"
> 
> I just saw that we have also a unix timezone Etc/UTC, this might be more appropriate
> (especially to avoid confusion with "GMT Standard Time", which is a separate entry in the file).
> 
>> +HKLM,%CurrentVersionNT%\Time Zones\UTC,"Dlt",,"Etc/GMT"
>> +HKLM,%CurrentVersionNT%\Time Zones\UTC,"Std",,"Etc/GMT"
> 
> For all other entries it contains a human readable name. Something like "Coordinated Universal Time" for both Dlt and Std might be a bit better.
> 
>> +HKLM,%CurrentVersionNT%\Time Zones\UTC,"TZI",1,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00,00
>> HKLM,%CurrentVersionNT%\Time Zones\Venezuela Standard Time,"Display",,"America/Caracas"
>> HKLM,%CurrentVersionNT%\Time Zones\Venezuela Standard Time,"Dlt",,"Venezuela Daylight Time"
>> HKLM,%CurrentVersionNT%\Time Zones\Venezuela Standard Time,"Std",,"Venezuela Standard Time"
>> 
> 
> Two other remarks:
> 
> * When you send an updated version, please append "(try N)" to your subject, to make clear which version is newer.
> * A subject starting with "wine.inf:" might be better, since your patch only touches this single file, not the loader itself.
> 
> Sorry for not pointing out all those things earlier.
> 
> Best regards,
> Sebastian
> 




More information about the wine-devel mailing list