[PATCH 0/3] mshtml: Image map support

[Alex Henrie]

2015-08-04 11:00 GMT-06:00 Jacek Caban <jacek at codeweavers.com>:
> The third patch needs more work. It would be nice to have event helper
> functions more generic as in if we want to use them for yet another
> element type, we wouldn't need to add another argument. Maybe callers
> should call appropriate GetHref and GetTarget and pass strings to the
> helper?

I pushed a new version of patch 3 to
https://github.com/alexhenrie/wine/commits/master - this version
shares less code between <a> and <area>, but it will be easier to use
the code in other places now. Any thoughts?

> Also, it would be nice to have a trivial test case for area element. See
> dom.c for an example. Just a call to test_elem_type for an area element
> should be enough for the stub.

I would add this, but I don't know where exactly to insert the test.
Would you be willing to write and submit this test, or at least tell
me which function in dom.c to add it to?

Even so, that test would have gone with patch 2, and Alexandre already
accepted that patch without tests, so we shouldn't have to wait to
submit patch 3 which definitely doesn't need new tests.

-Alex