[PATCH 2/7] d3d11/tests: Port test_create_texture2d() from d3d10core.

Henri Verbeet hverbeet at gmail.com
Mon Aug 10 01:48:56 CDT 2015


On 10 August 2015 at 01:11, Józef Kucia <jkucia at codeweavers.com> wrote:
> ---
>  configure                    |   3 +-
>  configure.ac                 |   3 +-
It's not a problem to include these, but it's not necessary either.
Alexandre will generate these with tools/make_makefiles before
committing the patch.

> +    if (!(device = create_device()))
> +    {
> +        skip("Failed to create device, skipping tests.\n");
> +        return;
> +    }
> +
There's nothing necessarily wrong with these tests, but you may want
to consider waiting with submitting them until after they pass. Right
now you're depending on create_device() to fail so the tests are
skipped, but that means that once D3D11CreateDevice() is implemented
you'd need to add todo_wine's and error handling to every test.



More information about the wine-devel mailing list