Implementation patches for d3drm's CreateDeviceFromD3D.

[Stefan Dösinger]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi,

They look quite good: One suggestion though: Do you need the separate
implementations for IDirect3DRM1 and IDirect3DRM3? It seems that you
could thunk d3drm2 and d3drm3 to d3drm1 and work with just one
implementation. That works because you don't need a separate way to
create the device like you do in the cases where you create the
immediate mode device yourself.

Yeah, I know that the thunk direction would be different from the
other methods, but I think that's something we can live with. The
thunk direction is forced by the IM device QI limitations and thunking
is preferred over code duplication if it's possible.

However, there's one thing you need to test first: can you QI
IDirect3DRMDevice3 from IDirect3DRMDevice(1)? Or do D3DRM Devices have
the same kind of restriction (down-QI'ing only) as IM devices?

Cheers,
Stefan

Am 2015-08-08 um 00:20 schrieb Aaryaman Vasishta:
> Attached is the patches for implementing CreateDeviceFromD3D.
> Please take a look and provide feedback, if any.
> 
> 
> 
> Thank you! Aaryaman

-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQIcBAEBAgAGBQJVyO4rAAoJEN0/YqbEcdMwHeQQAI8v5mJmRPhMlVkl5gnUu0ya
AWRdaN4+FE1WvicUP+RCb3qYiFqbSCsF/GIfLVHhE4J52mtiuhYRZ8d/gmPi1xZb
+6jusXxzz2RnXm9OHhapmdULQRA4JoTSk8cngiG49nT99V+5NMl6lVOhZnOdcddw
tVsRQIbSZa6g4xFwNA8QiEoBXNrJRLOyOggURdMP4tg4flx7WTlyqdtlpZ9K9Ykq
WTsypE8Cdo5elWuLpUT3uHpVudBD0GW9aN1SEJNJd/4/lYepyoeAUR9A1fmhgLEG
+xACD/uEFXwmXo1IoWOHfnS+HysXJGfMnRUQeJPScki3MkXncAJk+n70NvlX+fe8
WA5DIt0p2k19VR5h66uePaSQtdSPuBYEcvdsNafLUdzl2WsayxnRA87VLRQl5R6S
66/7X4AsXhxh9k/jnl9DFwfBvKQVMuarON06lNqS/pHoUP0/XGeis60PaqovmYiN
9wkG02jQnt9pGKp+4nCVn3nZwK1D2iMQeKatpCMH14f2rRRjIKjVSxCJ1bKYv3gp
cElRUBfL2nb8G+29HaAOuoRZ/VOzWcJD3ci0G+EeXNwjn/utFjXQptFHdUWoK7PV
CqRx0vOnuz4Tdl5cNZLGpQUbmBHJUww2RKoTrLuEz9NxK+bP/BxSLhrjyJzNoZhQ
O1APG6jnsjtMjC6gcZup
=u10f
-----END PGP SIGNATURE-----