[PATCH] msvcr120: Implement strtof and _strtof_l (try 3)
Bernhard Übelacker
bernhardu at vr-web.de
Sat Aug 15 08:55:07 CDT 2015
Am 14.08.2015 um 11:00 schrieb Henri Verbeet:
> On 14 August 2015 at 04:44, Bernhard Übelacker <bernhardu at vr-web.de> wrote:
>> + /*strtof*/
>> + f = p_strtof(float1, &end);
>> + ok(compare_float(f, 12.1, 4096), "f = %lf\n", f);
> Is it really that inaccurate, or did you just copy 4096 from the ddraw tests?
It is not that inaccurate and yes, I did just copy from the ddraw tests.
The constants I use in the test would allow for using 0 as ulps.
If I understand correctly a direct comparison would then also be
possible (at least on my system and testbot).
So should we remove the compare_float altogether and use a direct
comparison?
And if not, how many representable floats difference whould be suitable?
(The smallest value I see in other tests is 16.)
Thanks for reviewing.
Kind regards,
Bernhard
More information about the wine-devel
mailing list