[PATCH] shell32: Fix SHFileOperation(FO_MOVE) for creating subdirectories.

[Olivier F. R. Dierick]

Hello,

Thanks for providing that link to testbot data, I didn't know about it.

I guess we are stuck with it until the people in charge of the testbot
fix this. The best thing to do at the moment is to work on other parts
of the code, and when submitting patches to tests/shlfileop, ask
Alexandre to ignore that specific Vista testbot failure.

Regards,

Le samedi 15 août 2015 à 21:48 +0800, Zhenbo Li a écrit :
> Hello,
> 
> 2015-08-15 13:39 GMT+08:00 Olivier F. R. Dierick <o.dierick at piezo-forte.be>:
> >
> > The comments in your patch make it sound like there are multiple values
> > returned from Vista. It should not happen, hence the suggestion from
> > Alexandre Julliard to check the compiler version.
> >
> > However, my tests on the Wine Testbot tell me that Vista always returns
> > DE_FILEDESTISFLD. I've not seen Vista return any other value. I suppose
> > you didn't either. So we might be safe and assume that the original code
> > is wrong or dated or that the Vista labeling is a mistake.
> >
> No. I'm sure that some Vista computers won't return DE_FILEDESTISFLD
> 
> See http://test.winehq.org/data/tests/shell32:shlfileop.html
> 
> 
-- 
        Olivier F. R. Dierick
        o.dierick at piezo-forte.be