CreateDeviceFromD3D implementations, device QI tests and some other patches.

Stefan Dösinger stefandoesinger at gmail.com
Thu Aug 20 03:42:04 CDT 2015


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Hi,

- From patch 3:
> -    return IDirect3DDevice_QueryInterface(device->device, &IID_IDirect3DDevice2, (void**)d3d_device);
> +    *d3d_device = NULL;
> +    IDirect3DDevice_QueryInterface(device->device, &IID_IDirect3DDevice2, (void**)d3d_device);
I don't think you need the NULL assignment here,
d3ddevice::queryinterface does it for you in all error paths.

Other than that this looks good, feel free to send to wine-patches
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQIcBAEBAgAGBQJV1ZLcAAoJEN0/YqbEcdMwfFEP/Rm4DafDGxrAzQtrVMmwx3rg
E8P7pQ4A+tpmYN6fChw1GJAAyQsWMRJaYT4+Ke/6jM2kwfJJ2AUW46Tjmyvbx/Ic
cMT6PCTTOxQsNwYbjqMM5i4u6wzbw1ONYtvXpXezDA9RslyL3rw3XT/swYz/0+xT
vJdTudtNl5njpO2AVesS/8MYv+v1nPXpRYdtGqvB5kKHs5yyRpj+zfe3j1JucplT
xEzKBMclhv6fPSGBcvjfsW57p2LqoJ6RuubYzr325Pkz60V+dmgi6N1gGlfVmKWM
y+la/7DrLigY3Ww2IJpyVDZnjDqYTzSIjzUkUlfqru9kpG6Jc1C2gJ7R9TwQSiqb
MrYxCNHCetAQ20UzXXOAgDwUic8Y3fRzBUqz+SbuoDgU7ka+TxKZd09G0YC7/mFz
ZJXH308ugDybTnCl4I155eJYhCYFXsRRFOQsaF1ZNkOHzFCZHk8uszODQa1MvztA
gfQdml8WNKCytQEl53NAcYymsNCTjsU9DBEjrklpvZh8QJ/zxkuIPQEOJV65FlJu
+QxG6rRL60g3tOGXr42WlLhihoVsOXhp9GtbHG4U7mBWYlI4Sv6XtzQ/rFoZ/Zq3
kkkRtj0b7v7P6Mormqpriy+0KCZvTZ1++smo/Ck4rrCJ+aYtYoKtRSWB8iTe5rBf
XsxiSnPfe2X4PG+oiNUC
=K4OT
-----END PGP SIGNATURE-----



More information about the wine-devel mailing list