ws2_32: WSACleanup cleans up open sockets (OSX only)

Matt Durgavich mattdurgavich at gmail.com
Sat Aug 29 13:36:29 CDT 2015


Cool. Thanks for all the feedback. I’m happy to be contributing, and I got a crash course in server and dll development.

:)

> On Aug 29, 2015, at 2:19 PM, Bruno Jesus <00cpxxx at gmail.com> wrote:
> 
> On Sun, Aug 30, 2015 at 2:13 AM, Matt Durgavich <mattdurgavich at gmail.com> wrote:
>> All suggestions rolled in. Removing todos in tests will be a separate patch
> 
> You can't do that, because the changes you are making will break the
> tests (tests will fail since problems were fixed and todo_wine need to
> be removed). Just merge the todo removal and IMO the patch is fine.
> Remember to run make test inside the ws2_32/tests folder to check if
> it runs fine.
> 
> It amazes me that such a simple solution could be found for this bug,
> thanks for working on it and thanks Henri for the tip.




More information about the wine-devel mailing list