[PATCH 1/2] wined3d: Correctly parse SM4 dcl_immediateConstantBuffer opcode.

[Józef Kucia]

On Fri, Dec 4, 2015 at 2:56 PM, Henri Verbeet <hverbeet at gmail.com> wrote:
> But it doesn't actually allow the application to run, right? There's
> certainly something to say for limiting the scope of patches during
> the code freeze, but that's not necessarily the same as limiting the
> number of lines you touch. I think that for d3d10+ the potential for
> regressions is fairly limited at the moment, so in that regard adding
> the WINED3DSIH_ entry wouldn't concern me much. On the other hand,
> since (as far as I can tell) the patch doesn't make a substantial
> difference for the application in question, it could just as well be
> argued that the patch shouldn't go in at all during the code freeze.
>

Yes, let's defer that until after the code freeze.

> You're probably right. Still, it all seems pretty suspicious. For
> every other instruction so far the length is properly set. I suppose
> the issue is that the maximum size of immediate constant buffers
> (4096) is larger than the maximum value of the instruction length
> field. What does the actual bytecode look like? Any unrecognized
> flags?

It doesn't seem to have any unrecognized flags which could indicate
that the instruction length field should be ignored. I'll check it
more carefully when preparing a new version of this patch set after
the code freeze.