[PATCH] wined3d: Restore WINEDDBLT_ALPHATEST support.

Stefan Dösinger stefandoesinger at gmail.com
Tue Dec 8 17:39:36 CST 2015


> Am 08.12.2015 um 10:42 schrieb Henri Verbeet <hverbeet at gmail.com>:
> 
> You shouldn't need this. context_apply_blit_state() invalidates
> WINED3D_RS_ALPHATESTENABLE, but even if it didn't, disabling the alpha
> test isn't necessarily the right thing to do. Not that
> arbfp_blit_surface() necessarily needs all the invalidation
> context_apply_blit_state() does though.
Notice the last_was_blit check. Future blits might break if we keep the alpha test on.

We could discuss more fine-grained state tracking for blits, but I don't think 1.8 is the time for that, and even beyond that I don't think it's worth it. GLSL would just swap most of them by selecting its shader. I can do the same in ARB, but I don't think it matters either way.

> Some basic tests probably wouldn't hurt. If we had had any the
> regression might not have happened in the first place.
Agreed, but I probably won't get around to writing some before the weekend. The nature of the software cursor makes it a bit difficult. You can spot it via GetDC(NULL), but not through GetFrontBufferData on native. I'll see if I can find a way to write the test that doesn't fail on OSX by design. Also, Fullscreen only, windows doesn't do SW cursors in windowed mode. Alexandre will love another fullscreen test :-) .


-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 842 bytes
Desc: Message signed with OpenPGP using GPGMail
URL: <http://www.winehq.org/pipermail/wine-devel/attachments/20151208/a2010e7d/attachment.sig>


More information about the wine-devel mailing list