winepulse.drv: Add a winediag message when buffer is too small.

Andrew Eikum aeikum at codeweavers.com
Thu Dec 10 08:48:55 CST 2015


On Thu, Dec 10, 2015 at 03:27:24PM +0100, Sebastian Lackner wrote:
> Signed-off-by: Sebastian Lackner <sebastian at fds-team.de>
> ---
> 
> After pulseaudio was added, a lot of Debian people complained about missing sound. As it turns out,
> this was the result of a packaging "mistake". Debian wrapper scripts set PULSE_LATENCY_MSEC to small
> value by default, which worked fine with winealsa.
> 

More than "worked fine," it actually made winealsa work better for
some setups. So it was a good idea for winealsa, but is no longer
needed and causes problems for winepulse. See also Bug 39744 and
numerous references around the web to setting pulse's
default-fragment-size-msec, which equates to about the same thing.

> Even when the problem is fixed on Debian, the same problem might still occur when people have set
> PULSE_LATENCY_MSEC manually on their machine, and the value is too small. http://ix.io/mJp would
> be an alternative solution, but no longer allows users to control this environment variable manually.
> 

Yeah, I definitely don't want to override the user's settings.

> This patch adds at least a warning, so that users know which environment variable could be related
> when sound is suddenly missing after an upgrade. Comments welcome, would like to know Andrews opinion
> first how to proceed with this issue.
> 

Adding a warning seems like a good idea, but I would do it in
AudioClient_Initialize and remove the once-check. Around line 1340,
warn the user if tlength is less than bufsize_bytes.

Andrew



More information about the wine-devel mailing list