[PATCH 1/2] d3dx9_36/tests: Add D3DXSaveSurfaceToFileInMemory D3DXIFF_DDS tests (try 4)

[Christian Costa]

2015-12-11 16:02 GMT+01:00 Matteo Bruni <matteo.mystral at gmail.com>:

> 2015-12-11 10:59 GMT+01:00 Alistair Leslie-Hughes <
> leslie_alistair at hotmail.com>:
> > The DDS_CAPS_TEXTURE | DDSCAPS_ALPHA caps check was to address testbot
> failures
> > http://testbot.winehq.org/JobDetails.pl?Key=18888
>
> Yes, I understand that. What I meant is that I don't get the
> header->caps == DDS_CAPS_TEXTURE case ever, except on Wine,


Apparently the job shows that header->caps == DDS_CAPS_TEXTURE in 5 tests
corresponding to winxp, win2003, vista, win2008 and win7 and
DDS_CAPS_TEXTURE | DDSCAPS_ALPHA for 3 tests corresponding to win8 and
win10.
So if you never had header->caps == DDS_CAPS_TEXTURE, I'm wondering if you
ever launched tests on windows below win8.


> so the
> check should be simply:
>
> todo_wine ok(header->caps == (DDS_CAPS_TEXTURE | DDSCAPS_ALPHA),
>         "Got unexpected caps %x.\n", header->caps);
>
> Unless you can actually get that one to fail on Windows. If that's the
> case I'd like to know where does it fail for you.
>
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.winehq.org/pipermail/wine-devel/attachments/20151211/6f9200d1/attachment.html>