user32/tests: Use 'start' and 'end' variables in test comparisons

Hugh McMaster hugh.mcmaster at outlook.com
Thu Dec 17 05:44:55 CST 2015


On Thursday, 17 Dec 2015 19:26:53 +0800, Dmitry Timoshkov wrote:
> Hugh McMaster wrote:
>
>>> Hugh McMaster wrote:
>>>
>>>> - INT start,end;
>>>> + unsigned short start, end;
>>>
>>> This can't work.
>>
>> In this case it does - but it is a technicality.
>>
>> MSDN says typedef unsigned short WORD; but I should have used unsigned int here, as we cast to WPARAM / UINT_PTR.
>
> It doesn't matter what MSDN says or to what the code does the cast to.
> What matters is what the other side does with the passed in pointers.

Perhaps I'm misunderstanding your point. 

+ok(LOWORD(len)==start, "Unexpected start position for selection; got %u, expected 0\n", LOWORD(len));

It is a comparison between an unsigned short and unsigned int.  Do you want the change to unsigned int or not?
 		 	   		  


More information about the wine-devel mailing list