[PATCH 2/2] oledb32: GetConversionSize shouldn't fail for null variants.

Huw Davies Huw.Davies at physics.ox.ac.uk
Tue Dec 22 03:56:50 CST 2015


On 22 Dec 2015, at 09:28, Nikolay Sivov wrote:
> With previous patches my question was to test actual string this variant
> is converted too, maybe it's not that magic after all.

Looks like there's already a test for this (see the end of test_converttostr).
It doesn't return a string, but returns status DBSTATUS_S_ISNULL.

I think, given that's the case, you should add a comment above the new test,
stating that Windows returns 110, but we're not testing it.  Also remove the
initialization of dst_len before the call, since if we're not testing it there's no
need to initialize it.

Huw.




More information about the wine-devel mailing list