mmdevapi: Skip device if GetId fails (Coverity)
Andrew Eikum
aeikum at codeweavers.com
Tue Dec 22 13:05:42 CST 2015
Here too, please print a WARN.
Andrew
On Tue, Dec 22, 2015 at 07:35:02PM +0100, André Hentschel wrote:
> Signed-off-by: André Hentschel <nerv at dawncrow.de>
> ---
> CID 752979
>
> dlls/mmdevapi/devenum.c | 4 +++-
> 1 file changed, 3 insertions(+), 1 deletion(-)
>
> diff --git a/dlls/mmdevapi/devenum.c b/dlls/mmdevapi/devenum.c
> index d50d206..5f0ffba 100644
> --- a/dlls/mmdevapi/devenum.c
> +++ b/dlls/mmdevapi/devenum.c
> @@ -1065,9 +1065,11 @@ static HRESULT WINAPI MMDevEnum_GetDevice(IMMDeviceEnumerator *iface, const WCHA
>
> for (i = 0; i < MMDevice_count; ++i)
> {
> + HRESULT hr;
> WCHAR *str;
> dev = &MMDevice_head[i]->IMMDevice_iface;
> - IMMDevice_GetId(dev, &str);
> + hr = IMMDevice_GetId(dev, &str);
> + if (FAILED(hr)) continue;
>
> if (str && !lstrcmpW(str, name))
> {
> --
> 1.9.1
>
>
>
>
More information about the wine-devel
mailing list