[PATCH 1/2] dsound: Simplify error handling when creating a sound buffer.

Sebastian Lackner sebastian at fds-team.de
Tue Dec 22 17:57:29 CST 2015


On 22.12.2015 10:49, Michael Stefaniuc wrote:
> Signed-off-by: Michael Stefaniuc <mstefani at redhat.de>
> ---
> I run into this and wasted time while fixing the bug during the freeze.
> So I am submitting the dsound cleanups I have laying around.
> 
> 
>  dlls/dsound/buffer.c | 46 ++++++++++++++++------------------------------
>  1 file changed, 16 insertions(+), 30 deletions(-)
> 

Are you sure this will work as expected? The destructor makes assumptions
about specific variables to be initialized. If I don't miss anything,
DirectSoundDevice_RemoveBuffer could trigger an assertion / corrupt
nrofbuffers now. This->buffer->ref will also not be initialized. Could you
please double check that?




More information about the wine-devel mailing list