winspool: Remove dead code (Clang)
Alexandre Julliard
julliard at winehq.org
Wed Dec 23 02:23:45 CST 2015
André Hentschel <nerv at dawncrow.de> writes:
> @@ -4092,8 +4092,6 @@ static BOOL WINSPOOL_GetPrinter_1(HKEY hkeyPrinter, PRINTER_INFO_1W *pi1,
> if(WINSPOOL_GetStringFromReg(hkeyPrinter, DescriptionW, ptr, left, &size)) {
> if(space && size <= left) {
> pi1->pComment = (LPWSTR)ptr;
> - ptr += size;
> - left -= size;
> } else
> space = FALSE;
> *pcbNeeded += size;
There's a clear pattern to the code here, you don't want to break
it. I'd suggest redesigning the helper functions to avoid all this
duplication.
--
Alexandre Julliard
julliard at winehq.org
More information about the wine-devel
mailing list