winedump: Add initial version of old (SLTG) typelib dumper.

Alexandre Julliard julliard at winehq.org
Thu Dec 24 08:12:17 CST 2015


Dmitry Timoshkov <dmitry at baikal.ru> writes:

> +static int _isprint(unsigned char c)
>  {
> -    int i;
> +    return c >= 32 ? 1 : 0;

Please don't do that.

> +
> +    assert(print_hex("magic") == 0x47544c53);

Please don't do that.

> +    while (offset < name_table_start + name_table_size)
> +    {
> +/*printf("current offset: %08x (relative to name table start: %08x (%u))\n",
> +        offset, offset - name_table_start, offset - name_table_start);*/
> +        dump_binary(8);
> +        print_string0();
> +        printf("\n");
> +/*printf("current offset: %08x (relative to name table start: %08x (%u))\n",
> +        offset, offset - name_table_start, offset - name_table_start);*/

Please clean these up.

> +#if 0
> +    print_short_hex("unknown");
> +    print_short_hex("byte order mark");
> +    i = tlb_read_short();
> +    printf("version = %u.%u\n", i & 0xff, i >> 8);
> +    print_short_hex("system identifier");
> +    print_hex("unknown");
> +    printf("\n");
> +#else
> +    printf("skipping 12 bytes\n");
> +    dump_binary(12);
> +    printf("\n");
> +#endif

Same here.

-- 
Alexandre Julliard
julliard at winehq.org



More information about the wine-devel mailing list