mshtml: Add IHTMLXMLHttpRequest::responseXML() method implementation. (resend)

Zhenbo Li litimetal at gmail.com
Fri Dec 25 19:43:04 CST 2015


Hello Nikolay,

Thank you for viewing my patch on Christmas.

2015-12-26 6:56 GMT+08:00 Nikolay Sivov <bunglehead at gmail.com>:
> On 25.12.2015 10:30, Zhenbo Li wrote:
>> +static void test_illegal_xml(IXMLDOMDocument *xmldom)
>> +
>> +    last = (void*)0xdeadbeef;
>> +    hres = IXMLDOMDocument_get_lastChild(xmldom, &last);
>> +    ok(hres == S_FALSE, "get_lastChild failed: %08x\n", hres);
>> +    ok(last == NULL, "last != NULL\n");
>> +}
>
> It makes no sense to test every method on empty tree, test for text string.
>

I'm not sure that whether Windows will return an empty tree when
handling an illegal xml,
or being tolerant, return a non-empty tree.

>> +    hres = IXMLDOMDocument_QueryInterface(xmldoc, &IID_IObjectSafety, (void**)&safety);
>> +    assert(SUCCEEDED(hres));
>> +    hres = IObjectSafety_SetInterfaceSafetyOptions(safety, NULL,
>> +        INTERFACESAFE_FOR_UNTRUSTED_CALLER | INTERFACESAFE_FOR_UNTRUSTED_DATA | INTERFACE_USES_SECURITY_MANAGER,
>> +        INTERFACESAFE_FOR_UNTRUSTED_CALLER | INTERFACESAFE_FOR_UNTRUSTED_DATA | INTERFACE_USES_SECURITY_MANAGER);
>> +    assert(SUCCEEDED(hres));
>> +    IObjectSafety_Release(safety);
>
> This looks weird to me, why the asserts? Did Jacek suggest that?

This is discussed before wine 1.8
http://wine.1045685.n5.nabble.com/Re-mshtml-Add-IHTMLXMLHttpRequest-responseXML-method-implementation-try-2-td5860168.html

-- 
Have a nice day!
Zhenbo Li



More information about the wine-devel mailing list