[PATCH 1/3] dwrite: No need for return value in collection_find_family()

Alexandre Julliard julliard at winehq.org
Wed Feb 4 06:17:54 CST 2015


Nikolay Sivov <nsivov at codeweavers.com> writes:

> @@ -1424,11 +1424,14 @@ static HRESULT WINAPI dwritefontcollection_GetFontFamily(IDWriteFontCollection *
>      return create_fontfamily(This->family_data[index], iface, family);
>  }
>  
> -static HRESULT collection_find_family(struct dwrite_fontcollection *collection, const WCHAR *name, UINT32 *index, BOOL *exists)
> +static void collection_find_family(struct dwrite_fontcollection *collection, const WCHAR *name, UINT32 *index, BOOL *exists)

Returning the index instead would probably make the code cleaner.

-- 
Alexandre Julliard
julliard at winehq.org



More information about the wine-devel mailing list