include: add msasn1.h
Austin English
austinenglish at gmail.com
Thu Feb 5 14:46:31 CST 2015
On Thu, Feb 5, 2015 at 2:40 PM, Charles Davis <cdavis5x at gmail.com> wrote:
>
> > On Feb 5, 2015, at 1:20 PM, Austin English <austinenglish at gmail.com>
> wrote:
> > +typedef unsigned long ASN1uint32_t;
> > +typedef signed long ASN1int32_t;
> This won’t do what you (apparently) expect on 64-bit. At the very least,
> you should use ULONG/DWORD and LONG here.
>
> > +#ifndef WINAPI
> > +#define WINAPI __stdcall
> > +#endif
> This is most certainly wrong for Wine. I think you should include
> “windef.h” if you need WINAPI.
>
The same definition is made in include/bcrypt.h (I considered removing it,
then saw that it was already in bcrypt.h).
> I’m beginning to wonder if you copied this header (as well as <hidpi.h>)
> directly from Microsoft’s SDKs. You’ve been around long enough to know that
> that’s a big no-no around here.
>
No, mingw:
https://github.com/Alexpux/mingw-w64/blob/master/mingw-w64-headers/include/msasn1.h
https://gitorious.org/mingw/mingw-w32api/source/4c8646e262e08f79e290f5211ab9e7386a85c753:include/ddk/hidpi.h
--
-Austin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.winehq.org/pipermail/wine-devel/attachments/20150205/7d2712f4/attachment.html>
More information about the wine-devel
mailing list