[PATCH 3/5] opengl32: Introduce wrappers for glGetIntegerv and glGetStringi. (v2)

Alexandre Julliard julliard at winehq.org
Tue Feb 10 08:10:54 CST 2015


Matteo Bruni <matteo.mystral at gmail.com> writes:

> 2015-02-10 13:41 GMT+01:00 Alexandre Julliard <julliard at winehq.org>:
>> Matteo Bruni <mbruni at codeweavers.com> writes:
>>
>>> @@ -834,6 +849,9 @@ PROC WINAPI wglGetProcAddress( LPCSTR name )
>>>          *func_ptr = driver_func;
>>>      }
>>>
>>> +    if (!strcmp(name, "glGetStringi"))
>>> +        return (void *)glGetStringi;
>>
>> It seems to me you could handle this one through the extension table
>> instead of special casing it.
>
> Right, I can still go through the extension table just fine. It
> requires special handling in make_opengl instead but it does look
> nicer to me.
>
> Is the attached patch more like what you expected to see?

Yes, that's better.

-- 
Alexandre Julliard
julliard at winehq.org



More information about the wine-devel mailing list