[2/6] dxgi: Add interface for IDXGISurface1

Stefan Dösinger stefandoesinger at gmail.com
Tue Feb 10 08:34:20 CST 2015


-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Am 2015-02-10 um 12:41 schrieb Martell Malone:
Patch 3:
>> +typedef struct DXGI_OUTDUPL_MOVE_RECT {
>> +    POINT SourcePoint;
>> +    RECT DestinationRect;
>> +} DXGI_OUTDUPL_MOVE_RECT;
> { placement
> He didn't really specify this btw.
> The rest of the file has this format for the structs already.
> How do you want me to do this ?
Put them on the new line please, but don't touch existing code. In d3d code we always put them on a new line.

If you want you can later send a separate patch that changes the existing code without making any other change.

> I originally had the * at the right side in the first series of patches
> so when he told me to change that I assumed he meant move it to the
> left. I will move them back.
We always have them next to the declared variable or parameter (i.e., on the right side). The reason is that the other way (that is commonly used in C++) can lead to difficult to read code:

int* pointer, not_a_pointer;

> Can you give me an example of this please. Originally I had num_levels
> but he did say change to size.
> Does _countlevels suffice ? I'm not quite sure here
You consistently changed "num" to "count", as Henri asked for. But you're inconsistent re count_foo and foo_count.

> No I meant to have a newline at the end of the file.
> It appears I made the patches worse rather than better.
Don't worry, just be patient :-) .
-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQIcBAEBAgAGBQJU2hbsAAoJEN0/YqbEcdMwjOIP/2yfVGJCaT2WlF+Ol+n2w2UV
DX8WTi+CsP6IAM6Pdapeo4elLu2ggPQi7/BwOXz4frjOpHqxNVmpdesviBXJ1A3g
C3Rrcz2PCZ6RXBk9ZrIf3YHG6jjQ7XD/DXqg661VbYI5nPW5QzX7PyVMeSXnkvRn
CtmixHrXIhXzitKqGsuJzrdkwJm5bAAMeVlAKoroC1L4n9gQ/WsBNH0okJj2r9pQ
LSDWygawvX7l3rOgIkxNDre8t3dt5kBf2N+7erkwC/gnLYXUDrheJ7Oad1TCUm+A
4SZTnAGi66UTFLkMQUG43T3NRwfVOAzmnhzAPiwgqyul2dXf3fJ3qio3dnIrAwro
WXP6qmZdBeCOugpKlIUzKjX+KuJGJwkfyr2ydvPXHqcwvOffQIn/Shw3iwyWFleU
tQi8kCnn+hpA21mU1yOJin6nTNw5J+Zs5TwwjbuvQguIO/m9IX0N4DxaaZfyWV1H
6sd+O3+yAfdGu11X6G7VrKxU/k+XjdKhrwjckJjrzLIJ1HtNfwLpbngSwPx0GuM7
S1t2e3+E7idiFZrme/KpavKpq8ea4YipXLBEHZYV3hV5lFAGsoGFm1CHw944hNOf
ewY7DrBLGEXJ7bj+33q9TpMqwCSqFub3jxYt6NnE/201bhEn3lVilWnB3RZWh53H
JEI4H/7HxZ2/SQs6sPSe
=kAH4
-----END PGP SIGNATURE-----



More information about the wine-devel mailing list