[PATCH 4/4] wininet: Always use winsock sockets.

Jacek Caban jacek at codeweavers.com
Sat Feb 14 11:25:52 CST 2015


On 02/14/15 14:31, Sebastian Lackner wrote:
> On 14.02.2015 14:22, Jacek Caban wrote:
>> On 13/02/15 20:00, Sebastian Lackner wrote:
>>> This patch causes build failures on our Ubuntu Precise builders. I don't have a machine to test it directly, but somehow unistd.h is still included indirectly:
>>>
>>> In file included from http.c:37:0:
>>> ../../include/ws2tcpip.h:57:13: error: conflicting types for 'socklen_t'
>>> /usr/include/unistd.h:275:21: note: previous declaration of 'socklen_t' was here
>>>
>>> Full build log:
>>> https://launchpadlibrarian.net/197555168/buildlog_ubuntu-precise-i386.wine-staging_1.7.37~daily-201502131701~ubuntu12.04.1_FAILEDTOBUILD.txt.gz
>>>
>> It looks like zlib.h is including unistd.h. Could you, or anyone else seeing this error, send me zlib.h and zconf.h so I may take a look.
>>
>> Thanks,
>> Jacek
> Good guess, that it at least one of the ways how it still gets included. I've grabbed the corresponding files from the Ubuntu precise package:
> http://packages.ubuntu.com/precise/zlib1g-dev
>
> zlib.h includes zconf.h, which includes zlibdefs.h. And this one contains a reference to unistd.h. Attaching all three header files for reference.

Thanks, I just sent patches that should fix these build failures. They
apply on top of my yesterday wininet patches.

Cheers,
Jacek



More information about the wine-devel mailing list