[PATCH] winepulse: add audio driver

Alexandre Julliard julliard at winehq.org
Mon Feb 16 03:22:29 CST 2015


Andrew Eikum <aeikum at codeweavers.com> writes:

> On Thu, Feb 12, 2015 at 03:46:24PM +0200, Damjan Jovanovic wrote:
>> AFAIK, even if for no other reason, this patch will probably be
>> rejected because it patches configure, as opposed to just patching
>> configure.ac and requesting configure to be regenerated.
>
> That's a good point.
>
>> It might also have a better chance if broken up into several patches.
>
> There isn't really a good way to split it up. I don't see any sense in
> submitting an unimplemented or half-broken driver.

Of course, but I'm sure it could still be split in slightly more
digestible chunks.  More importantly, changes made by different authors
need to be separate patches, with proper attribution.

-- 
Alexandre Julliard
julliard at winehq.org



More information about the wine-devel mailing list