[PATCH 4/4] wininet: Always use winsock sockets.

Jacek Caban jacek at codeweavers.com
Mon Feb 16 04:16:02 CST 2015

Hi Francois,

On 02/15/15 12:50, Francois Gouget wrote:
> On Sat, 14 Feb 2015, Jacek Caban wrote:
> [...]
>> Thanks, I just sent patches that should fix these build failures. They
>> apply on top of my yesterday wininet patches.
> The patch does fix the build. It should however also remove the use of 
> Z_SOLO since it's not needed anymore.

Yes, good catch, thanks. I meant to remove that. It should also fix
builds on FreeBSD. I will resend the whole series.

> I came up with a different solution: move the zlib code to its own C 
> file to isolate it from the rest, and particularly from anything related 
> to winsock. I'm attaching the patch in case there's interest.

I thought about that too, but it seemed to me like more invasive than it
has to be. How about we take my patches and if we find that it's still
problematic, we take your patch?

> The inet_ntoa() part may still make sense.

Yes, it's worth taking regardless solution we choose.


More information about the wine-devel mailing list