[PATCH 4/5] wined3d: Reject unsupported pitches in wined3d_surface_update_desc().

Henri Verbeet hverbeet at gmail.com
Wed Feb 18 11:18:13 CST 2015

On 18 February 2015 at 17:25, Stefan Dösinger <stefandoesinger at gmail.com> wrote:
> Fwiw, I don't have strong feelings about this, so feel free to do what
> you think fits best. My thinking is that the entire patch is based on
> assumptions about the client libraries.
The conceptual difference is that if we just reject the pitch in
wined3d it becomes part of the API, so if e.g. ddraw tries to set an
invalid pitch that's ddraw's problem. While if we don't, it's like
we're pretending that pitches like that are supported, but we really
hope nothing ever uses them, so if something sets an invalid pitch
it's wined3d's problem to make it work somehow. The distinction is of
course a bit artificial because everything is under our control, but
the former seems more proper to me.

> If this assumption breaks it's
> worth making the resulting message more verbose than a WARN.
Possibly, although at least ddraw_surface_create() will already print
an ERR if wined3d_texture_update_desc() fails.

More information about the wine-devel mailing list