[PATCH 1/3] ntdll/tests: Add tests for RtlIpv4StringToAddressEx, RtlIpv6StringToAddress (try 2)

[Mark Jansen]

Hello,

I do not agree with this (combining the test into one table):
Any sensible implementation will have the Ex function call the non-Ex
function to handle the ip parsing part,
in which case it does not serve any purpose to run all tests again for
the Ex function (essentially just re-testing the non-Ex function).
Besides that, sharing the table between the functions means having
separate results for the Ex and non-Ex in the same table,
and what is the point of one shared table then?

regards,

On Mon, Feb 16, 2015 at 12:02 PM, Stefan Dösinger
<stefandoesinger at gmail.com> wrote:
> -----BEGIN PGP SIGNED MESSAGE-----
> Hash: SHA1
>
> Hi,
>
> I've already talked to Mark about this on #winehackers, just repeating
> it for the list: My remaining request with these tests is that I
> believe we should test the full set of inputs against the Ex and
> non-Ex versions and ideally reuse the test table (for base and ex, not
> for ipv4 and ipv6). That will tell us if there's any difference in the
> IP parsing part of the base and Ex functions. It'll also be
> interesting how the base function handles ports in the string, and, in
> case of ipv6, brackets around the IP.
>
> Other than that two minor style issues: Change the subject of patch
> one (it only handles RtlIpv4StringToAddressEx), and you still have
> different levels of indentation in the line continuations of some ok()
> statements.
>
> Cheers,
> Stefan
>
> Am 2015-02-15 um 18:02 schrieb Mark Jansen:
>> Add test for RtlIpv4StringToAddressEx
>>
>> --- dlls/ntdll/tests/rtl.c | 101
>> +++++++++++++++++++++++++++++++++++++++++++++++++ 1 file changed,
>> 101 insertions(+)
>>
>>
>>
>>
>
> -----BEGIN PGP SIGNATURE-----
> Version: GnuPG v2
>
> iQIcBAEBAgAGBQJU4c5HAAoJEN0/YqbEcdMwnPIP/RT2i0fG4cPqKikwa26VbRyn
> EG2yeG78Wjx/vysLuQfGe8alhUycGrgMzW4N4m8QiAx/xNFv4eX0OdI+5gYMbSHK
> dYZSzTSKbqoJbnBlZwt1MoaaNceX/zIEy2WoaRCYpsUJfpscT/sOdJ+/gW55gDkH
> 605vvruhgJFSFVeZDVzfR9gQcY51iHB0KDemX2p1mwHElr6+HwYSHOQt+8KCL8YV
> wfC87NSMEAfEjIudYPL7SFHvUuLr3GoHBBt57R9p/2gNT7eJ7ll9ANvShFkRENjL
> jmKJQj7exehqrAGNWBqbeIPSjHBQoGl/UZPwIE39UioNhRo+sWi5A8tBbUMyL3o5
> VENuxL987kU1L9Xpa6/jEcrQksgafCa742/wWSAjPGE0D2iTUr0hQN0zQoioTPA/
> zuaDyDO3CBCyFaF0A9h9FzxOkuRAHo6TSKw0IYOrI2XENAoqQ+B+fX0ll9t/5Tu0
> iUIea06yp2/fRButo58sJNAd3dUZpRKf1qT+Eu7Cn+AJfgi3TsKY/Lw0gvyb4XJh
> qOdp7EPzqY1PURn6+Z8aDwNZRA2du3NM91SSMfwz+qwZtakf8K/XtkpC1CpNLONJ
> kfltxHVALBKT0NTDzvprrSzvTVH90hJLE+nX/E5Qf6SzeRVqxsPomBtOj2VLuapZ
> 4ehIhXsaEJJz9jc31tr9
> =E0dA
> -----END PGP SIGNATURE-----