makedep: Sanitize the module names before turning them into resource ids.

Alexandre Julliard julliard at winehq.org
Mon Feb 23 21:10:41 CST 2015


Francois Gouget <fgouget at free.fr> writes:

> On Fri, 20 Feb 2015, Alexandre Julliard wrote:
> [...]
>> There's no reason that resource ids can't contain dashes,
>
> You're right, it's a bug in wrc.
>
> The simple fix would be to add '-' to the set of allowed characters for 
> tIDENT but in fact the resource and type ids (and probably filenames) 
> can contain pretty much any character. That's much harder to handle in 
> the parser however :-(

Yes, cf. bug 786.

>> and besides, winetest won't know what to do with it if you change the 
>> name.
>
> I did test and that worked... just had to use underscores.

I don't see how winetest can find the dll if it's using underscores.

-- 
Alexandre Julliard
julliard at winehq.org



More information about the wine-devel mailing list