[PATCH 4/5] d3d9/tests: Remove a couple duplicate lines.
Matteo Bruni
matteo.mystral at gmail.com
Mon Jan 5 10:48:27 CST 2015
2015-01-05 17:37 GMT+01:00 Bruno Jesus <00cpxxx at gmail.com>:
> On Mon, Jan 5, 2015 at 2:17 PM, Matteo Bruni <mbruni at codeweavers.com> wrote:
>
> Ciao, Matteo.
>
>> ---
>> dlls/d3d9/tests/visual.c | 2 --
>> 1 file changed, 2 deletions(-)
>>
>> diff --git a/dlls/d3d9/tests/visual.c b/dlls/d3d9/tests/visual.c
>> index d1aa3d4..acc3a44 100644
>> --- a/dlls/d3d9/tests/visual.c
>> +++ b/dlls/d3d9/tests/visual.c
>> @@ -6775,8 +6775,6 @@ static void pretransformed_varying_test(void)
>> hr = IDirect3DDevice9_SetVertexDeclaration(device, decl);
>> ok(hr == D3D_OK, "IDirect3DDevice9_SetVertexDeclaration returned %08x\n", hr);
>>
>> - hr = IDirect3DDevice9_SetVertexDeclaration(device, decl);
>> - ok(hr == D3D_OK, "IDirect3DDevice9_SetVertexDeclaration returned %08x\n", hr);
>
> Isn't this done on purpose to check if double setting works?
The idea might have been that but I don't think this is interesting to
test. Actually it looks more like the side effect of multiple separate
changes done over the course of the years over that piece of code.
> Distinti Saluti,
> Bruno
Cheers ;)
More information about the wine-devel
mailing list