feedback on my valgrind related patches

Marc Bessières marc.bessieres at mykolab.com
Wed Jan 14 06:49:11 CST 2015


Hello,

I know you are very busy, so sorry to disturb you.

One month ago I submitted 2 valgrind related patches:
http://source.winehq.org/patches/data/108226
and
http://source.winehq.org/patches/data/108223

I also attach them to this mail.

They are still in NEW, and I think after one month they go out of the queue.
According to the legend it means they've not been looked at yet.

Do you know what I can do to have some feedback for them?
I tried to create commit messages as complete as possible to explain each 
change.
I didn't add any regression test, because the valgrind errors were triggered 
by the existing tests.
I presume that was not good enough though, but I'm willing to improve if I'm 
given some guidance.

Cheers,
Marc
-------------- next part --------------
An embedded message was scrubbed...
From: marc.bessieres at mykolab.com
Subject: gdi32: uninitialized dst_info->bmiHeader.biBitCount in GetDIBits(valgrind)
Date: Sun, 14 Dec 2014 15:11:24 +0100
Size: 2605
URL: <http://www.winehq.org/pipermail/wine-devel/attachments/20150114/3b445c1e/attachment.mht>
-------------- next part --------------
An embedded message was scrubbed...
From: marc.bessieres at mykolab.com
Subject: gdi32: uninitialized biCompression in GetDIBits(valgrind) (try 2)
Date: Sun, 14 Dec 2014 13:22:47 +0100
Size: 4388
URL: <http://www.winehq.org/pipermail/wine-devel/attachments/20150114/3b445c1e/attachment-0001.mht>


More information about the wine-devel mailing list