[PATCH (try 3) 2/2] dpvoice: Turn GetCompressionTypes into a semi-stub.

[Stefan Dösinger]

-----BEGIN PGP SIGNED MESSAGE-----
Hash: SHA1

Am 2015-01-17 um 19:23 schrieb Alex Henrie:
> A proper enumeration would take a lot of effort because it changes 
> depending on whether certain DLLs are present, and not all of
> those DLLs are present in Wine. Also, the strings would have to be 
> localized.
This would probably work by the DLLs registering themselves in the
registry and dpvoice enumerating the registry keys. The codecs
probably already register themselves.

> Most of dpvoice is patent-protected in the United States:
> 
> https://www.google.com/patents/US7720908 
> https://www.google.com/patents/US7730206
> 
> GetCompressionTypes is one of the few pieces that we can legally
> implement.
> 
> Fortunately, practically nothing actually uses dpvoice. Star Trek 
> Armada II doesn't even use dpvoice, it's just a dependency of its
> game engine.
I think under these circumstances adding a semi-stub like yours that
makes a game work better is a reasonable thing to do.

> Getting rid of the Hungarian notation in
> DPVOICE_GetCompressionTypes would make it look odd next to the
> other 3 functions declared in dvoice_private.h. Maybe after these
> two patches are committed, we could work on another patch to
> uniformly eliminate the Hungarian notation throughout dpvoice.
Generally style-only changes are discouraged and the right thing to do
is to change the style when you're changing the code for other
reasons. I personally disagree with that rule since it makes the same
style issues pop up again and again and again.


-----BEGIN PGP SIGNATURE-----
Version: GnuPG v2

iQIcBAEBAgAGBQJUvA8xAAoJEN0/YqbEcdMwu1UP/0GRPvR8VEanomFu0jJujT86
o2MRJldHb/dfS4N7ZyJSxAPi000AlsGkI+ocZn/+kavmgKbHhHbsWkJW6jygJg1K
iSWyY/ziVTRM4Bphij85wzlJl+tYzquM8q4wde1OIA6UHnc/CYTwsAtECx5MuRIK
OBA//e9xvm42G/LyyqM3EIZcSwduJcAULoDWcaPxnlhhN3DfLesGOs27h69C2Ypl
OAcD+qnWmWFb2o5eyZ0dK/1RHJi5MgTRBDhATCq88nDaDmuL1dP4WNe85+wkX34/
4Z2+4gSTlujdB61VYfOlixO0XtIgHGQNs4H+qt4q8aPr0XeADT+fSYV/b6XKU+oI
LITTqLiDaWmo4eqhA71XzhN3+9+zn67rPpR23pwlOiHWWiM9VtVsJ+yR6Da3qWbB
mSpRUFb9Slq/4ciYWqWXKPfsp/rG51hrqWXxpn4L5eDfHW0XPSAjzj93JTH1TEmh
+vyjp1T2ik+92m4TjWASpGaxhrGRYK0lG9LZEma01PUTMbFk6Tz3lS+ILq24wJ6o
HPEJBxWQ2PzlljRVBrgMZ/8mC8lkeKjNStKG3KlX1Ufu894cx9pdt4OeBSIACYLG
uoCHBz213nztSS4pYpoxW+UrBb5QEp/ekXVr8gSpoOTVUhmf3WnVmwzaGRhb4j7l
NS0OFRsVQUL5E7TtLyfF
=JwKc
-----END PGP SIGNATURE-----