[PATCH 1/2] kernel32/tests: Make loader tests independent from each other

Nikolay Sivov nsivov at codeweavers.com
Wed Jan 28 09:26:54 CST 2015


On 28.01.2015 18:20, Dmitry Timoshkov wrote:
>> +const static IMAGE_NT_HEADERS nt_header_template =
> 'static const' is a commonly accepted order.
>
> There are various reasons of the current tests structure, if you are not
> planning to add new tests please leave the code as it is please.
>
Are you going to name those reasons? Currently some tests depend on 
values set by previous tests.
That's clearly a broken behavior. test_import_resolution() does it right 
already by the way.

So why should I leave it as it is?




More information about the wine-devel mailing list