[PATCH 1/2] kernel32/tests: Make loader tests independent from each other

Dmitry Timoshkov dmitry at baikal.ru
Wed Jan 28 09:39:28 CST 2015


Nikolay Sivov <nsivov at codeweavers.com> wrote:

> > There are various reasons of the current tests structure, if you are not
> > planning to add new tests please leave the code as it is please.
> >
> Are you going to name those reasons?

I don't think it's really important unless you are going to add new tests.

> Currently some tests depend on 
> values set by previous tests.
> That's clearly a broken behavior. test_import_resolution() does it right 
> already by the way.
> 
> So why should I leave it as it is?

There is no actual reason to touch it, and these purely cosmetic changes
create conflicts with the tests I have in local tree.

-- 
Dmitry.



More information about the wine-devel mailing list