[PATCH 1/6]: msvcp110: Add tr2_sys__Copy_file implementation and test.

YongHaoHu christopherwuy at gmail.com
Wed Jul 1 00:08:28 CDT 2015

Hi, Piotr.

On 15/6/30 下午8:25, Piotr Caban wrote:
>>> Currently your implementation sometimes returns error even so it
>>> succeeds.
>> Which one do you mean ? As you know, last_error hadling is not correct
>> in wine's CopyFile, was this happened in Wine platform?
> { "f1", "tr2_test_dir\\f1_copy", TRUE }
> Your implementation returns error if f1_copy file already exists. It 
> only makes sense to use GetLastError if function have failed.
I had tested the ret and the last_error before in testbot. The result 
shows that the function's return value is exactly the same as 
         ret = p_tr2_sys__Copy_file(tests[i].source, tests[i].dest, 
         printf("ret is %d\n", ret);
         printf("GetLastError is %d\n\n", GetLastError());

Here is the test result: 
And { "f1", "tr2_test_dir\\f1_copy", TRUE } returns 80( ERROR_FILE_EXSITS).

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://www.winehq.org/pipermail/wine-devel/attachments/20150701/2250b6b4/attachment.html>

More information about the wine-devel mailing list