[PATCH 4/5] wined3d: Add a setting for the maximum OpenGL version to use.

[Matteo Bruni]

2015-07-07 19:43 GMT+02:00 Matteo Bruni <matteo.mystral at gmail.com>:
> 2015-07-07 19:12 GMT+02:00 Henri Verbeet <hverbeet at gmail.com>:
>> On 7 July 2015 at 18:37, Matteo Bruni <matteo.mystral at gmail.com> wrote:
>>> 2015-07-07 16:58 GMT+02:00 Henri Verbeet <hverbeet at gmail.com>:
>>>>> +    glGetIntegerv(GL_CONTEXT_PROFILE_MASK, &context_profile);
>>>>> +    if (glGetError() != GL_NO_ERROR)
>>>>> +        context_profile = 0;
>>>> Should this perhaps just check for
>>>> gl_info->p_wglCreateContextAttribsARB instead of eating errors?
>>>
>>> You mean just check whether wglCreateContextAttribsARB succeeded for a
>>> GL version >= 3.2? That should work, although it might be a bit
>>> awkward (but not necessarily more than the current code).
>>>
>> I actually meant "if (gl_info->p_wglCreateContextAttribsARB)", but
>> that doesn't work because the query is only supported on 3.2 or later
>> contexts. But we could probably just check "gl_version" against 3.2
>> instead.
>
> Yeah, that's probably easier.
>

Actually no, we can't, I just remembered. Linux binary drivers offer
compatibility contexts and will return the latest supported GL version
even if you create a 1.0 context. We don't want to enable the wined3d
3.2 codepath there.