[PATCH 4/6] propsys: Implement named properties, serialization on the in-memory store

Jonas Kümmerlin rgcjonas at gmail.com
Wed Jul 15 15:00:21 CDT 2015

Vincent Povirk wrote:
> Maybe you know this, but this patch does too many things and will 
> need
> to be split before sending to wine-patches.
I suspected that, and a rework is in progress (the patches originally
eaten by the list need that badly, too).

> +    if (!psps && !cb) /* special case: empty storage */
> Is it really not enough to have a size of 0? The buffer has to be 
> NULL as well?
I don't think so, size 0 should be enough. I'll add a test.

> +    /* MSDN mandates generic error codes */
> MSDN's lists of error codes aren't necessarily exhaustive.
Oops. I generally claim to be aware of this fact.

More information about the wine-devel mailing list