[PATCH] advapi32: test and fix ChangeServiceConfig2 when given a zero length or a null description (try2, resend)

Huw Davies Huw.Davies at physics.ox.ac.uk
Mon Jul 20 02:55:51 CDT 2015

On 17 Jul 2015, at 20:15, Bernhard Übelacker wrote:
> On two attempts to send a patch modifying the service tests I got a failing
> test in the "w7u" VM while the other VMs were succeeding [1][2][3].
> This test first gets the number of active and inactive services.
> Then enumerates all services and decrements the corresponding counter.
> At the end both counter should be zero.

Yes, there's clearly a race in the tests.  What's more, this failure happens
before your new code and is clearly not related to it.

Of course it would be nice to fix the race, but that doesn't seem possible the
way the existing tests are written.


More information about the wine-devel mailing list