[1/2] ntdll/tests: Add basic tests for RtlQueueWorkItem.

Grazvydas Ignotas notasas at gmail.com
Tue Jul 28 08:53:57 CDT 2015


On Mon, Jul 27, 2015 at 1:33 AM, Sebastian Lackner
<sebastian at fds-team.de> wrote:
> On 27.07.2015 00:11, Marvin wrote:
>> Hi,
>>
>> While running your changed tests on Windows, I think I found new failures.
>> Being a bot and all I'm not very good at pattern recognition, so I might be
>> wrong, but could you please double-check?
>> Full results can be found at
>> https://testbot.winehq.org/JobDetails.pl?Key=15580
>>
>> Your paranoid android.
>>
>>
>> === w7u (32 bit threadpool) ===
>> threadpool.c:763: Test failed: WaitForSingleObject returned 258
>> threadpool.c:777: Test failed: WaitForSingleObject returned 0
>> threadpool.c:779: Test failed: threadpool.c:715: Running timer callback
>>
>
> This is unrelated to my tests.
>
> If noone has an idea what is causing these random failures I'll try to increase
> the timeouts a bit (in a separate patch of course) - however, these random issues
> do not occur on a local Windows 7 machine, which makes me suspect that it could
> also be related to testbot issues.

IMHO 1s timeouts are way too low for test machines running on VMs, the
host machine may not have enough resources if multiple VMs are busy,
and the hypervisor may have it's inefficiencies too, especially when
I/O is involved. I don't have any idea how tesbot is set up bit I had
an impression there are lots of VMs running on a single host.

If it was up to me I'd increase those timeouts a lot, to at least 10s
(or even a minute) instead of 1s.

Gražvydas



More information about the wine-devel mailing list