[PATCH] mshtml: add NULL check to get_frame_by_name

Jacek Caban jacek at codeweavers.com
Mon Jun 1 10:38:40 CDT 2015


On 05/29/15 15:51, Indrek Altpere wrote:
> Fixes https://bugs.winehq.org/show_bug.cgi?id=34982
> ---
>  dlls/mshtml/htmlwindow.c | 5 +++++
>  1 file changed, 5 insertions(+)
>
> diff --git a/dlls/mshtml/htmlwindow.c b/dlls/mshtml/htmlwindow.c
> index 618648e..c53ea16 100644
> --- a/dlls/mshtml/htmlwindow.c
> +++ b/dlls/mshtml/htmlwindow.c
> @@ -406,6 +406,11 @@ HRESULT get_frame_by_name(HTMLOuterWindow *This, const WCHAR *name, BOOL deep, H
>  
>          nsIDOMWindow_Release(nswindow);
>  
> +        if(!window_iter) {
> +            WARN("nsIDOMWindow without HTMLOuterWindow: %p\n", nswindow);
> +            continue;
> +        }
> +

The real question is why there is no HTMLOuterWindow created for given
window, but I'm fine with the patch.

Thanks,
Jacek



More information about the wine-devel mailing list